Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0b7528d9 authored by Saravana Kannan's avatar Saravana Kannan Committed by Rafael J. Wysocki
Browse files

cpufreq: stats: Fix error handling in __cpufreq_stats_create_table() 



Remove sysfs group if __cpufreq_stats_create_table() fails after creating
one.

Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarSaravana Kannan <skannan@codeaurora.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent b24a5b65

drivers/cpufreq/cpufreq_stats.c

+3 −1
Original line number Diff line number Diff line
@@ -216,7 +216,7 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy, 
	stat->time_in_state = kzalloc(alloc_size, GFP_KERNEL);

	if (!stat->time_in_state) {

		ret = -ENOMEM;

		goto error_out;

		goto error_alloc;

	}

	stat->freq_table = (unsigned int *)(stat->time_in_state + count);
@@ -237,6 +237,8 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy, 
	stat->last_index = freq_table_get_index(stat, policy->cur);

	spin_unlock(&cpufreq_stats_lock);

	return 0;

error_alloc:

	sysfs_remove_group(&policy->kobj, &stats_attr_group);

error_out:

	kfree(stat);

	per_cpu(cpufreq_stats_table, cpu) = NULL;