Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b24a5b65 authored by Saravana Kannan's avatar Saravana Kannan Committed by Rafael J. Wysocki
Browse files

cpufreq: stats: Remove redundant cpufreq_cpu_get() call 



__cpufreq_stats_create_table always gets pass the valid and real policy
struct. So, there's no need to call cpufreq_cpu_get() to get the policy
again.

Acked-by: default avatarViresh Kumar <viresh.kumar@linaro.org>
Signed-off-by: default avatarSaravana Kannan <skannan@codeaurora.org>
Signed-off-by: default avatarRafael J. Wysocki <rafael.j.wysocki@intel.com>
parent d98d099b

drivers/cpufreq/cpufreq_stats.c

+1 −11
Original line number Diff line number Diff line
@@ -185,7 +185,6 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy, 
{

	unsigned int i, j, count = 0, ret = 0;

	struct cpufreq_stats *stat;

	struct cpufreq_policy *current_policy;

	unsigned int alloc_size;

	unsigned int cpu = policy->cpu;

	if (per_cpu(cpufreq_stats_table, cpu))
@@ -194,13 +193,7 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy, 
	if ((stat) == NULL)

		return -ENOMEM;



	current_policy = cpufreq_cpu_get(cpu);

	if (current_policy == NULL) {

		ret = -EINVAL;

		goto error_get_fail;

	}



	ret = sysfs_create_group(&current_policy->kobj, &stats_attr_group);

	ret = sysfs_create_group(&policy->kobj, &stats_attr_group);

	if (ret)

		goto error_out;
@@ -243,11 +236,8 @@ static int __cpufreq_stats_create_table(struct cpufreq_policy *policy, 
	stat->last_time = get_jiffies_64();

	stat->last_index = freq_table_get_index(stat, policy->cur);

	spin_unlock(&cpufreq_stats_lock);

	cpufreq_cpu_put(current_policy);

	return 0;

error_out:

	cpufreq_cpu_put(current_policy);

error_get_fail:

	kfree(stat);

	per_cpu(cpufreq_stats_table, cpu) = NULL;

	return ret;