Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fd968115 authored by Stefan Agner's avatar Stefan Agner Committed by Linus Walleij
Browse files

gpio: vf610: handle level IRQ's properly 



The GPIO IRQ controller is able to generate level triggered
interrupts, however, these were handled by handle_simple_irq so far
which did not take care of IRQ masking. This lead to "nobody cared
(try booting with the "irqpoll" option)" stack traces.

Use the generic interrupt handlers depending on the IRQ type.

Signed-off-by: default avatarStefan Agner <stefan@agner.ch>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 78de5d52

drivers/gpio/gpio-vf610.c

+8 −1
Original line number Diff line number Diff line
@@ -60,6 +60,8 @@ struct vf610_gpio_port { 
#define PORT_INT_EITHER_EDGE	0xb

#define PORT_INT_LOGIC_ONE	0xc



static struct irq_chip vf610_gpio_irq_chip;



static const struct of_device_id vf610_gpio_dt_ids[] = {

	{ .compatible = "fsl,vf610-gpio" },

	{ /* sentinel */ }
@@ -173,6 +175,11 @@ static int vf610_gpio_irq_set_type(struct irq_data *d, u32 type) 


	port->irqc[d->hwirq] = irqc;



	if (type & IRQ_TYPE_LEVEL_MASK)

		__irq_set_handler_locked(d->irq, handle_level_irq);

	else

		__irq_set_handler_locked(d->irq, handle_edge_irq);



	return 0;

}
@@ -263,7 +270,7 @@ static int vf610_gpio_probe(struct platform_device *pdev) 
	vf610_gpio_writel(~0, port->base + PORT_ISFR);



	ret = gpiochip_irqchip_add(gc, &vf610_gpio_irq_chip, 0,

				   handle_simple_irq, IRQ_TYPE_NONE);

				   handle_edge_irq, IRQ_TYPE_NONE);

	if (ret) {

		dev_err(dev, "failed to add irqchip\n");

		gpiochip_remove(gc);