Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 78de5d52 authored by Nicholas Krause's avatar Nicholas Krause Committed by Linus Walleij
Browse files

gpio: max732x: Fix error handling in probe() 



This fixes error handling in the function max732x_probe by checking
if the calls to the function max732x_readb fail by returning a error
code.

Signed-off-by: default avatarNicholas Krause <xerofoify@gmail.com>
Signed-off-by: default avatarLinus Walleij <linus.walleij@linaro.org>
parent 5d9452e7

drivers/gpio/gpio-max732x.c

+8 −3
Original line number Diff line number Diff line
@@ -685,9 +685,14 @@ static int max732x_probe(struct i2c_client *client, 


	mutex_init(&chip->lock);



	max732x_readb(chip, is_group_a(chip, 0), &chip->reg_out[0]);

	if (nr_port > 8)

		max732x_readb(chip, is_group_a(chip, 8), &chip->reg_out[1]);

	ret = max732x_readb(chip, is_group_a(chip, 0), &chip->reg_out[0]);

	if (ret)

		goto out_failed;

	if (nr_port > 8) {

		ret = max732x_readb(chip, is_group_a(chip, 8), &chip->reg_out[1]);

		if (ret)

			goto out_failed;

	}



	ret = gpiochip_add(&chip->gpio_chip);

	if (ret)