Commit f778a636 authored Sep 19, 2012 by Mathias Krause Committed by David S. Miller Sep 20, 2012

xfrm_user: fix info leak in copy_to_user_state()



The memory reserved to dump the xfrm state includes the padding bytes of
struct xfrm_usersa_info added by the compiler for alignment (7 for
amd64, 3 for i386). Add an explicit memset(0) before filling the buffer
to avoid the info leak.

Signed-off-by: Mathias Krause <minipli@googlemail.com>
Acked-by: Steffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: David S. Miller <davem@davemloft.net>

parent 4c87308b

net/xfrm/xfrm_user.c

+1 −0

Original line number	Diff line number	Diff line
		@@ -689,6 +689,7 @@ static int xfrm_del_sa(struct sk_buff skb, struct nlmsghdr nlh,

		static void copy_to_user_state(struct xfrm_state x, struct xfrm_usersa_info p)
		{
		memset(p, 0, sizeof(*p));
		memcpy(&p->id, &x->id, sizeof(p->id));
		memcpy(&p->sel, &x->sel, sizeof(p->sel));
		memcpy(&p->lft, &x->lft, sizeof(p->lft));