Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c87308b authored by Mathias Krause's avatar Mathias Krause Committed by David S. Miller
Browse files

xfrm_user: fix info leak in copy_to_user_auth() 



copy_to_user_auth() fails to initialize the remainder of alg_name and
therefore discloses up to 54 bytes of heap memory via netlink to
userland.

Use strncpy() instead of strcpy() to fill the trailing bytes of alg_name
with null bytes.

Signed-off-by: default avatarMathias Krause <minipli@googlemail.com>
Acked-by: default avatarSteffen Klassert <steffen.klassert@secunet.com>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent 9db273f4

net/xfrm/xfrm_user.c

+1 −1
Original line number Diff line number Diff line
@@ -742,7 +742,7 @@ static int copy_to_user_auth(struct xfrm_algo_auth *auth, struct sk_buff *skb) 
		return -EMSGSIZE;



	algo = nla_data(nla);

	strcpy(algo->alg_name, auth->alg_name);

	strncpy(algo->alg_name, auth->alg_name, sizeof(algo->alg_name));

	memcpy(algo->alg_key, auth->alg_key, (auth->alg_key_len + 7) / 8);

	algo->alg_key_len = auth->alg_key_len;