Commit ebca4cda authored Oct 16, 2007 by Oleg Nesterov Committed by Linus Torvalds Oct 17, 2007

zap_other_threads: don't optimize thread_group_empty() case



Nowadays thread_group_empty() and next_thread() are simple list operations,
this optimization doesn't make sense: we are doing exactly same check one
line below.

Signed-off-by: Oleg Nesterov <oleg@tv-sign.ru>
Acked-by: Roland McGrath <roland@redhat.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 3ae4cbad

kernel/signal.c

+0 −3

Original line number	Diff line number	Diff line
		@@ -985,9 +985,6 @@ void zap_other_threads(struct task_struct *p)
		p->signal->flags = SIGNAL_GROUP_EXIT;
		p->signal->group_stop_count = 0;

		if (thread_group_empty(p))
		return;

		for (t = next_thread(p); t != p; t = next_thread(t)) {
		/*
		* Don't bother with already dead threads