Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3ae4cbad authored by Oleg Nesterov's avatar Oleg Nesterov Committed by Linus Torvalds
Browse files

exit_notify: don't take tasklist for TIF_SIGPENDING re-targeting 



->siglock provides enough protection to iterate over the thread group.

Signed-off-by: default avatarOleg Nesterov <oleg@tv-sign.ru>
Acked-by: default avatarRoland McGrath <roland@redhat.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 2f4e6e2a

kernel/exit.c

+1 −4
Original line number Diff line number Diff line
@@ -747,13 +747,11 @@ static void exit_notify(struct task_struct *tsk) 
		 * Now we'll wake all the threads in the group just to make

		 * sure someone gets all the pending signals.

		 */

		read_lock(&tasklist_lock);

		spin_lock_irq(&tsk->sighand->siglock);

		for (t = next_thread(tsk); t != tsk; t = next_thread(t))

			if (!signal_pending(t) && !(t->flags & PF_EXITING))

				recalc_sigpending_and_wake(t);

		spin_unlock_irq(&tsk->sighand->siglock);

		read_unlock(&tasklist_lock);

	}



	write_lock_irq(&tasklist_lock);
@@ -781,7 +779,6 @@ static void exit_notify(struct task_struct *tsk) 
	 * and we were the only connection outside, so our pgrp

	 * is about to become orphaned.

	 */

	 

	t = tsk->real_parent;



	pgrp = task_pgrp(tsk);