Commit e88d251d authored Jun 16, 2015 by Russell King Committed by Thomas Gleixner Jun 18, 2015

gpio: gpio-tegra: Fix race in installing chained IRQ handler



Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Signed-off-by: Russell King <rmk+kernel@arm.linux.org.uk>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/E1Z4z0M-0002Sl-Ti@rmk-PC.arm.linux.org.uk


Signed-off-by: Thomas Gleixner <tglx@linutronix.de>

parent a44735f4

drivers/gpio/gpio-tegra.c

+2 −2

Original line number	Diff line number	Diff line
		@@ -515,8 +515,8 @@ static int tegra_gpio_probe(struct platform_device *pdev)
		for (i = 0; i < tegra_gpio_bank_count; i++) {
		bank = &tegra_gpio_banks[i];

		irq_set_chained_handler(bank->irq, tegra_gpio_irq_handler);
		irq_set_handler_data(bank->irq, bank);
		irq_set_chained_handler_and_data(bank->irq,
		tegra_gpio_irq_handler, bank);

		for (j = 0; j < 4; j++)
		spin_lock_init(&bank->lvl_lock[j]);