Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a44735f4 authored by Russell King's avatar Russell King Committed by Thomas Gleixner
Browse files

gpio: gpio-mxs: Fix race in installing chained IRQ handler 



Fix a race where a pending interrupt could be received and the handler
called before the handler's data has been setup, by converting to
irq_set_chained_handler_and_data().

Signed-off-by: default avatarRussell King <rmk+kernel@arm.linux.org.uk>
Cc: Alexandre Courbot <gnurou@gmail.com>
Cc: Hans Ulli Kroll <ulli.kroll@googlemail.com>
Cc: Jason Cooper <jason@lakedaemon.net>
Cc: Lee Jones <lee.jones@linaro.org>
Cc: Linus Walleij <linus.walleij@linaro.org>
Cc: Thierry Reding <thierry.reding@gmail.com>
Cc: linux-arm-kernel@lists.infradead.org
Link: http://lkml.kernel.org/r/E1Z4z0H-0002Sf-P9@rmk-PC.arm.linux.org.uk


Signed-off-by: default avatarThomas Gleixner <tglx@linutronix.de>
parent e65eea54

drivers/gpio/gpio-mxs.c

+2 −2
Original line number Diff line number Diff line
@@ -320,8 +320,8 @@ static int mxs_gpio_probe(struct platform_device *pdev) 
	mxs_gpio_init_gc(port, irq_base);



	/* setup one handler for each entry */

	irq_set_chained_handler(port->irq, mxs_gpio_irq_handler);

	irq_set_handler_data(port->irq, port);

	irq_set_chained_handler_and_data(port->irq, mxs_gpio_irq_handler,

					 port);



	err = bgpio_init(&port->bgc, &pdev->dev, 4,

			 port->base + PINCTRL_DIN(port),