Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit dc875c77 authored by Rui Miguel Silva's avatar Rui Miguel Silva Committed by Greg Kroah-Hartman
Browse files

staging: greybus: light: check delay_{on|off} before use 



Even though we trust leds core that the pointers should be valid, we are
safer to check delay_{on|off} before use.

Also, this avoid a smatch warning:
drivers/staging/greybus/light.c:484 gb_blink_set()
warn: variable dereferenced before check 'delay_on' (see line 476)

Signed-off-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 3855eeec

drivers/staging/greybus/light.c

+3 −0
Original line number Diff line number Diff line
@@ -463,6 +463,9 @@ static int gb_blink_set(struct led_classdev *cdev, unsigned long *delay_on, 
	if (channel->releasing)

		return -ESHUTDOWN;



	if (!delay_on || !delay_off)

		return -EINVAL;



	mutex_lock(&channel->lock);

	ret = gb_pm_runtime_get_sync(bundle);

	if (ret < 0)