Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3855eeec authored by Rui Miguel Silva's avatar Rui Miguel Silva Committed by Greg Kroah-Hartman
Browse files

staging: greybus: light: fix attributes allocation 



Fix allocation of attributes with the correct size, this also fix smatch
warning:

drivers/staging/greybus/light.c:293 channel_attr_groups_set()
warn: double check that we're allocating correct size: 8 vs 16

Signed-off-by: default avatarRui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 85a42dc8

drivers/staging/greybus/light.c

+1 −2
Original line number Diff line number Diff line
@@ -290,8 +290,7 @@ static int channel_attr_groups_set(struct gb_channel *channel, 
		return 0;



	/* Set attributes based in the channel flags */

	channel->attrs = kcalloc(size + 1, sizeof(**channel->attrs),

				 GFP_KERNEL);

	channel->attrs = kcalloc(size + 1, sizeof(*channel->attrs), GFP_KERNEL);

	if (!channel->attrs)

		return -ENOMEM;

	channel->attr_group = kcalloc(1, sizeof(*channel->attr_group),