Commit 85a42dc8 authored Sep 30, 2016 by Rui Miguel Silva Committed by Greg Kroah-Hartman Oct 02, 2016

staging: greybus: sdio: fix cmd_flags check for none response



When checking for command flags field if response is not available we
really need to compare it with the right define and not bitwise AND it.

smatch warn:
        drivers/staging/greybus/sdio.c:481 gb_sdio_command()
        warn: bitwise AND condition is false here

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Rui Miguel Silva <rmfrfs@gmail.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 71bad7f0

drivers/staging/greybus/sdio.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -478,7 +478,7 @@ static int gb_sdio_command(struct gb_sdio_host host, struct mmc_command cmd)
		goto out;

		/* no response expected */
		if (cmd_flags & GB_SDIO_RSP_NONE)
		if (cmd_flags == GB_SDIO_RSP_NONE)
		goto out;

		/* long response expected */