Commit bc8201e3 authored Jun 05, 2016 by Hans de Goede Committed by Greg Kroah-Hartman Jun 17, 2016

Revert "Staging: rtl8188eu: rtw_efuse: Use sizeof type *pointer instead of sizeof type."



This reverts commit b5e12ec3 ("Staging: rtl8188eu: rtw_efuse: Use
sizeof type *pointer instead of sizeof type.").

This commit is wrong, the rtw_malloc2d helper function takes the size of
the array elements as its 3th argument, whereas sizeof(*eFuseWord)
gives the size of a pointer instead of the size of a u16.

Since sizeof(void *) > sizeof(u16) this has no adverse effects, but it
is still wrong.

Cc: Sandhya Bankar <bankarsandhya512@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 6982f867

drivers/staging/rtl8188eu/core/rtw_efuse.c

+1 −1

Original line number	Diff line number	Diff line
		@@ -102,7 +102,7 @@ efuse_phymap_to_logical(u8 phymap, u16 _offset, u16 _size_byte, u8 pbuf)
		if (!efuseTbl)
		return;

		eFuseWord = (u16 *)rtw_malloc2d(EFUSE_MAX_SECTION_88E, EFUSE_MAX_WORD_UNIT, sizeof(eFuseWord));
		eFuseWord = (u16 **)rtw_malloc2d(EFUSE_MAX_SECTION_88E, EFUSE_MAX_WORD_UNIT, sizeof(u16));
		if (!eFuseWord) {
		DBG_88E("%s: alloc eFuseWord fail!\n", __func__);
		goto eFuseWord_failed;