Commit 6982f867 authored Jun 05, 2016 by Hans de Goede Committed by Greg Kroah-Hartman Jun 17, 2016

Revert "Staging: drivers: rtl8188eu: use sizeof(*ptr) instead of sizeof(struct)"



This reverts commit 99aded71 ("Staging: drivers: rtl8188eu: use
sizeof(*ptr) instead of sizeof(struct)").

This commit is wrong, as adapt->HalData has a type of "void *", so
now we are allocating a much to small struct, which causes the driver
to overwrite random memory which leads to a non working driver and
various system crashes.

Cc: Jacky Boen <aqiank@gmail.com>
Signed-off-by: Hans de Goede <hdegoede@redhat.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent a9cc4006

drivers/staging/rtl8188eu/hal/usb_halinit.c

+2 −1

Original line number	Diff line number	Diff line
		@@ -2072,7 +2072,8 @@ void rtl8188eu_set_hal_ops(struct adapter *adapt)
		{
		struct hal_ops *halfunc = &adapt->HalFunc;

		adapt->HalData = kzalloc(sizeof(*adapt->HalData), GFP_KERNEL);

		adapt->HalData = kzalloc(sizeof(struct hal_data_8188e), GFP_KERNEL);
		if (!adapt->HalData)
		DBG_88E("cant not alloc memory for HAL DATA\n");