Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit a9cc4006 authored by Doug Oucharek's avatar Doug Oucharek Committed by Greg Kroah-Hartman
Browse files

staging: lustre: lnet: Don't access NULL NI on failure path 



In kiblnd_passive_connect(), if we are failing the connection
attempt because we cannot find a valid NI (we have a NULL NI),
we were coring after the "goto fail" because the failure
path was assuming non-NULL NI.

This patch ensures we don't dereference a NULL NI on that
failure path.

Signed-off-by: default avatarDoug Oucharek <doug.s.oucharek@intel.com>
Intel-bug-id: https://jira.hpdd.intel.com/browse/LU-8022
Reviewed-on: http://review.whamcloud.com/19614


Reviewed-by: default avatarDmitry Eremin <dmitry.eremin@intel.com>
Reviewed-by: default avatarJames Simmons <uja.ornl@yahoo.com>
Reviewed-by: default avatarMatt Ezell <ezellma@ornl.gov>
Reviewed-by: default avatarOleg Drokin <oleg.drokin@intel.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 03cce00b

drivers/staging/lustre/lnet/klnds/o2iblnd/o2iblnd_cb.c

+4 −3
Original line number Diff line number Diff line
@@ -2521,12 +2521,13 @@ kiblnd_passive_connect(struct rdma_cm_id *cmid, void *priv, int priv_nob) 
	return 0;



 failed:

	if (ni)

	if (ni) {

		lnet_ni_decref(ni);



	rej.ibr_version             = version;

		rej.ibr_cp.ibcp_queue_depth = kiblnd_msg_queue_size(version, ni);

		rej.ibr_cp.ibcp_max_frags = kiblnd_rdma_frags(version, ni);

	}



	rej.ibr_version             = version;

	kiblnd_reject(cmid, &rej);



	return -ECONNREFUSED;