Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 9b721a4c authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: usb_8dev: don't touch skb after netif_rx() 



There is no guarantee that the skb is in the same state after calling
net_receive_skb() or netif_rx(). It might be freed or reused. Not really
harmful as its a read access, except you turn on the proper debugging options
which catch a use after free.

Cc: Bernd Krumboeck <b.krumboeck@gmail.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 43c021e8

drivers/net/can/usb/usb_8dev.c

+2 −4
Original line number Diff line number Diff line
@@ -461,10 +461,9 @@ static void usb_8dev_rx_err_msg(struct usb_8dev_priv *priv, 
	priv->bec.txerr = txerr;

	priv->bec.rxerr = rxerr;



	netif_rx(skb);



	stats->rx_packets++;

	stats->rx_bytes += cf->can_dlc;

	netif_rx(skb);

}



/* Read data and status frames */
@@ -494,10 +493,9 @@ static void usb_8dev_rx_can_msg(struct usb_8dev_priv *priv, 
		else

			memcpy(cf->data, msg->data, cf->can_dlc);



		netif_rx(skb);



		stats->rx_packets++;

		stats->rx_bytes += cf->can_dlc;

		netif_rx(skb);



		can_led_event(priv->netdev, CAN_LED_EVENT_RX);

	} else {