Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 43c021e8 authored by Marc Kleine-Budde's avatar Marc Kleine-Budde
Browse files

can: ems_usb: don't touch skb after netif_rx() 



There is no guarantee that the skb is in the same state after calling
net_receive_skb() or netif_rx(). It might be freed or reused. Not really
harmful as its a read access, except you turn on the proper debugging options
which catch a use after free.

Cc: Gerhard Uttenthaler <uttenthaler@ems-wuensche.com>
Signed-off-by: default avatarMarc Kleine-Budde <mkl@pengutronix.de>
parent 296decb6

drivers/net/can/usb/ems_usb.c

+2 −4
Original line number Diff line number Diff line
@@ -324,10 +324,9 @@ static void ems_usb_rx_can_msg(struct ems_usb *dev, struct ems_cpc_msg *msg) 
			cf->data[i] = msg->msg.can_msg.msg[i];

	}



	netif_rx(skb);



	stats->rx_packets++;

	stats->rx_bytes += cf->can_dlc;

	netif_rx(skb);

}



static void ems_usb_rx_err(struct ems_usb *dev, struct ems_cpc_msg *msg)
@@ -400,10 +399,9 @@ static void ems_usb_rx_err(struct ems_usb *dev, struct ems_cpc_msg *msg) 
		stats->rx_errors++;

	}



	netif_rx(skb);



	stats->rx_packets++;

	stats->rx_bytes += cf->can_dlc;

	netif_rx(skb);

}



/*