Commit 982d255b authored May 23, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman May 30, 2013

staging: comedi: usbduxsigma: remove unnecessary check in usbdux_ao_cmd()



The comedi core verifies that the command chanlist_len is valid for
the subdevice based on the len_chanlist that was setup during the
attach. There is no need to recheck it in the (*cmd) function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 01a4303d

drivers/staging/comedi/drivers/usbduxsigma.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -1189,12 +1189,6 @@ static int usbdux_ao_cmd(struct comedi_device dev, struct comedi_subdevice s)
		for (i = 0; i < cmd->chanlist_len; ++i) {
		chan = CR_CHAN(cmd->chanlist[i]);
		gain = CR_RANGE(cmd->chanlist[i]);
		if (i >= NUMOUTCHANNELS) {
		dev_err(&this_usbduxsub->interface->dev,
		"comedi%d: %s: channel list too long\n",
		dev->minor, __func__);
		break;
		}
		this_usbduxsub->dac_commands[i] = chan;
		dev_dbg(&this_usbduxsub->interface->dev,
		"comedi%d: dac command for ch %d is %x\n",