Commit 01a4303d authored May 23, 2013 by H Hartley Sweeten Committed by Greg Kroah-Hartman May 30, 2013

staging: comedi: usbduxsigma: remove unnecessary check in usbdux_ai_cmd()



The comedi core verifies that the command chanlist_len is valid for
the subdevice based on the len_chanlist that was setup during the
attach. There is no need to recheck it in the (*cmd) function.

Signed-off-by: H Hartley Sweeten <hsweeten@visionengravers.com>
Cc: Ian Abbott <abbotti@mev.co.uk>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 8eea6dbd

drivers/staging/comedi/drivers/usbduxsigma.c

+0 −6

Original line number	Diff line number	Diff line
		@@ -818,12 +818,6 @@ static int usbdux_ai_cmd(struct comedi_device dev, struct comedi_subdevice s)
		for (i = 0; i < cmd->chanlist_len; i++) {
		chan = CR_CHAN(cmd->chanlist[i]);
		create_adc_command(chan, &muxsg0, &muxsg1);
		if (i >= NUMCHANNELS) {
		dev_err(&this_usbduxsub->interface->dev,
		"comedi%d: channel list too long\n",
		dev->minor);
		break;
		}
		}
		this_usbduxsub->dux_commands[5] = muxsg0;
		this_usbduxsub->dux_commands[6] = muxsg1;