Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 7ce24ab7 authored by Larry Finger's avatar Larry Finger Committed by John W. Linville
Browse files

rtlwifi: rtl8723be: Fix smatch warnings 



Smatch reports the following:

drivers/net/wireless/rtlwifi/rtl8723be/fw.c:208 _rtl8723be_fill_h2c_command() warn: variable dereferenced before check 'rtlhal' (see line 69)
drivers/net/wireless/rtlwifi/rtl8723be/hw.c:1732 _rtl8723be_read_adapter_info() error: __builtin_memcpy() '&rtlefuse->efuse_map[0][0]' too small (256 vs 512)

The first one is fixed by removing two pointless tests for NULL pointers.

Reported-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarLarry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 2903d04b

drivers/net/wireless/rtlwifi/rtl8723be/fw.c

+0 −8
Original line number Diff line number Diff line
@@ -201,14 +201,6 @@ static void _rtl8723be_fill_h2c_command(struct ieee80211_hw *hw, u8 element_id, 
			 "pHalData->last_hmeboxnum  = %d\n",

			 rtlhal->last_hmeboxnum);

	}

	if (!rtlpriv) {

		pr_err("rtlpriv bad\n");

		return;

	}

	if (!rtlhal) {

		pr_err("rtlhal bad\n");

		return;

	}

	spin_lock_irqsave(&rtlpriv->locks.h2c_lock, flag);

	rtlhal->h2c_setinprogress = false;

	spin_unlock_irqrestore(&rtlpriv->locks.h2c_lock, flag);

drivers/net/wireless/rtlwifi/wifi.h

+1 −1
Original line number Diff line number Diff line
@@ -1587,7 +1587,7 @@ struct rtl_dm { 
	u64 last_rx_ok_cnt;

};



#define	EFUSE_MAX_LOGICAL_SIZE			256

#define	EFUSE_MAX_LOGICAL_SIZE			512



struct rtl_efuse {

	bool autoLoad_ok;