Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 2903d04b authored Mar 05, 2014 by Larry Finger Committed by John W. Linville Mar 06, 2014

rtlwifi: rtl8723be: Fix sparse errors



Sparse reports the following:

drivers/net/wireless/rtlwifi/rtl8723be/sw.c:374:14: sparse: duplicate const

drivers/net/wireless/rtlwifi/rtl8723be/hw.c:2214:30: sparse: cast to restricted __le32

Reported-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
Signed-off-by: John W. Linville <linville@tuxdriver.com>

parent 2d9d532f

drivers/net/wireless/rtlwifi/rtl8723be/hw.c

+1 −2

Original line number	Original line	Diff line number	Diff line
	@@ -2210,8 +2210,7 @@ static void rtl8723be_update_hal_rate_mask(struct ieee80211_hw *hw,

	RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG,		RT_TRACE(rtlpriv, COMP_RATR, DBG_DMESG,
	"ratr_bitmap :%x\n", ratr_bitmap);		"ratr_bitmap :%x\n", ratr_bitmap);
	(u32 )&rate_mask = EF4BYTE((ratr_bitmap & 0x0fffffff) \|		(u32 )&rate_mask = (ratr_bitmap & 0x0fffffff) \| (ratr_index << 28);
	(ratr_index << 28));
	rate_mask[0] = macid;		rate_mask[0] = macid;
	rate_mask[1] = _rtl8723be_mrate_idx_to_arfr_id(hw, ratr_index) \|		rate_mask[1] = _rtl8723be_mrate_idx_to_arfr_id(hw, ratr_index) \|
	(shortgi ? 0x80 : 0x00);		(shortgi ? 0x80 : 0x00);

drivers/net/wireless/rtlwifi/rtl8723be/sw.c

+1 −1

Original line number	Original line	Diff line number	Diff line
	@@ -370,7 +370,7 @@ MODULE_PARM_DESC(ips, "using no link power save (default 1 is open)\n");
	MODULE_PARM_DESC(fwlps, "using linked fw control power save (default 1 is open)\n");		MODULE_PARM_DESC(fwlps, "using linked fw control power save (default 1 is open)\n");
	MODULE_PARM_DESC(debug, "Set debug level (0-5) (default 0)");		MODULE_PARM_DESC(debug, "Set debug level (0-5) (default 0)");

	static const SIMPLE_DEV_PM_OPS(rtlwifi_pm_ops, rtl_pci_suspend, rtl_pci_resume);		static SIMPLE_DEV_PM_OPS(rtlwifi_pm_ops, rtl_pci_suspend, rtl_pci_resume);

	static struct pci_driver rtl8723be_driver = {		static struct pci_driver rtl8723be_driver = {
	.name = KBUILD_MODNAME,		.name = KBUILD_MODNAME,