Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 757dd82e authored by Matthias Schiffer's avatar Matthias Schiffer Committed by Antonio Quartulli
Browse files

batman-adv: check for more types of invalid IP addresses in DAT 



There are more types of IP addresses that may appear in ARP packets that we
don't want to process. While some of these should never appear in sane ARP
packets, a 0.0.0.0 source is used for duplicate address detection and thus seen
quite often.

Signed-off-by: default avatarMatthias Schiffer <mschiffer@universe-factory.net>
Acked-by: default avatarAntonio Quartulli <ordex@autistici.org>
Signed-off-by: default avatarMarek Lindner <lindner_marek@yahoo.de>
Signed-off-by: default avatarAntonio Quartulli <ordex@autistici.org>
parent 0d15bece

net/batman-adv/distributed-arp-table.c

+3 −1
Original line number Original line Diff line number Diff line
@@ -777,7 +777,9 @@ static uint16_t batadv_arp_get_type(struct batadv_priv *bat_priv, 
	ip_src = batadv_arp_ip_src(skb, hdr_size);

	ip_src = batadv_arp_ip_src(skb, hdr_size);

	ip_dst = batadv_arp_ip_dst(skb, hdr_size);

	ip_dst = batadv_arp_ip_dst(skb, hdr_size);

	if (ipv4_is_loopback(ip_src) || ipv4_is_multicast(ip_src) ||

	if (ipv4_is_loopback(ip_src) || ipv4_is_multicast(ip_src) ||

	    ipv4_is_loopback(ip_dst) || ipv4_is_multicast(ip_dst))

	    ipv4_is_loopback(ip_dst) || ipv4_is_multicast(ip_dst) ||

	    ipv4_is_zeronet(ip_src) || ipv4_is_lbcast(ip_src) ||

	    ipv4_is_zeronet(ip_dst) || ipv4_is_lbcast(ip_dst))

		goto out;

		goto out;





	type = ntohs(arphdr->ar_op);

	type = ntohs(arphdr->ar_op);