Commit 0d15bece authored Jan 23, 2013 by Matthias Schiffer Committed by Antonio Quartulli Jan 27, 2013

batman-adv: fix skb leak in batadv_dat_snoop_incoming_arp_reply()

The callers of batadv_dat_snoop_incoming_arp_reply() assume the skb has been
freed when it returns true; fix this by calling kfree_skb before returning as
it is done in batadv_dat_snoop_incoming_arp_request().

Signed-off-by: Matthias Schiffer <mschiffer@universe-factory.net>
Signed-off-by: Marek Lindner <lindner_marek@yahoo.de>
Acked-by: Antonio Quartulli <ordex@autistici.org>
Signed-off-by: Antonio Quartulli <ordex@autistici.org>

parent 1591ab67

net/batman-adv/distributed-arp-table.c

+2 −0

Original line number	Diff line number	Diff line
		@@ -1012,6 +1012,8 @@ bool batadv_dat_snoop_incoming_arp_reply(struct batadv_priv *bat_priv,
		*/
		ret = !batadv_is_my_client(bat_priv, hw_dst);
		out:
		if (ret)
		kfree_skb(skb);
		/* if ret == false -> packet has to be delivered to the interface */
		return ret;
		}