Commit 6ea6392c authored Mar 16, 2011 by Fabio Estevam Committed by Sascha Hauer Mar 23, 2011

ARM: mx5/mx53_evk: Use gpio_request_one in mx53_evk_fec_reset

Current code inside mx53_evk_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value right after. This is not needed.

By using gpio_request_one it is possible to set the direction and initial value in one shot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

parent ce191e41

arch/arm/mach-mx5/board-mx53_evk.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -82,13 +82,12 @@ static inline void mx53_evk_fec_reset(void)
		int ret;

		/* reset FEC PHY */
		ret = gpio_request(SMD_FEC_PHY_RST, "fec-phy-reset");
		ret = gpio_request_one(SMD_FEC_PHY_RST, GPIOF_OUT_INIT_LOW,
		"fec-phy-reset");
		if (ret) {
		printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
		return;
		}
		gpio_direction_output(SMD_FEC_PHY_RST, 0);
		gpio_set_value(SMD_FEC_PHY_RST, 0);
		msleep(1);
		gpio_set_value(SMD_FEC_PHY_RST, 1);
		}