Commit ce191e41 authored Mar 16, 2011 by Fabio Estevam Committed by Sascha Hauer Mar 23, 2011

ARM: mx5/babbage: Use gpio_request_one in babbage_fec_reset

Current code inside babbage_fec_reset uses gpio_direction_output with initial value of the GPIO and also sets
the GPIO value via gpio_set_value to the same level right after. This is not needed.

By using gpio_request_one it is possible to set the direction and initial value in one shot.

Signed-off-by: Fabio Estevam <fabio.estevam@freescale.com>
Acked-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
Signed-off-by: Sascha Hauer <s.hauer@pengutronix.de>

parent 14fb20c9

arch/arm/mach-mx5/board-mx51_babbage.c

+2 −3

Original line number	Diff line number	Diff line
		@@ -228,13 +228,12 @@ static inline void babbage_fec_reset(void)
		int ret;

		/* reset FEC PHY */
		ret = gpio_request(BABBAGE_FEC_PHY_RESET, "fec-phy-reset");
		ret = gpio_request_one(BABBAGE_FEC_PHY_RESET,
		GPIOF_OUT_INIT_LOW, "fec-phy-reset");
		if (ret) {
		printk(KERN_ERR"failed to get GPIO_FEC_PHY_RESET: %d\n", ret);
		return;
		}
		gpio_direction_output(BABBAGE_FEC_PHY_RESET, 0);
		gpio_set_value(BABBAGE_FEC_PHY_RESET, 0);
		msleep(1);
		gpio_set_value(BABBAGE_FEC_PHY_RESET, 1);
		}