Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6cf38956 authored by Santosh Shilimkar's avatar Santosh Shilimkar
Browse files

ARM: OMAP4: PM: Remove L4 wakeup depedency with MPU since errata fix exist now 



With commit bfd6d021 {ARM: OMAP3+: Implement timer workaround for errata
i103 and i767}, the sync and gptimer synchronization errata got fixed.

Hence the l4_wakeup static dependency with MPU can  can be removed
now. Static dependency was one of the proposed workaround but from
power savings perspective, it isn't an ideal workaround.

Acked-by: default avatarKevin Hilman <khilman@deeprootsystems.com>
Signed-off-by: default avatarSantosh Shilimkar <santosh.shilimkar@ti.com>
parent b699ddd1

arch/arm/mach-omap2/pm44xx.c

+2 −8
Original line number Diff line number Diff line
@@ -143,7 +143,7 @@ static void omap_default_idle(void) 
int __init omap4_pm_init(void)

{

	int ret;

	struct clockdomain *emif_clkdm, *mpuss_clkdm, *l3_1_clkdm, *l4wkup;

	struct clockdomain *emif_clkdm, *mpuss_clkdm, *l3_1_clkdm;

	struct clockdomain *ducati_clkdm, *l3_2_clkdm, *l4_per_clkdm;



	if (omap_rev() == OMAP4430_REV_ES1_0) {
@@ -171,19 +171,14 @@ int __init omap4_pm_init(void) 
	 * MPUSS -> L4_PER/L3_* and DUCATI -> L3_* doesn't work as

	 * expected. The hardware recommendation is to enable static

	 * dependencies for these to avoid system lock ups or random crashes.

	 * The L4 wakeup depedency is added to workaround the OCP sync hardware

	 * BUG with 32K synctimer which lead to incorrect timer value read

	 * from the 32K counter. The BUG applies for GPTIMER1 and WDT2 which

	 * are part of L4 wakeup clockdomain.

	 */

	mpuss_clkdm = clkdm_lookup("mpuss_clkdm");

	emif_clkdm = clkdm_lookup("l3_emif_clkdm");

	l3_1_clkdm = clkdm_lookup("l3_1_clkdm");

	l3_2_clkdm = clkdm_lookup("l3_2_clkdm");

	l4_per_clkdm = clkdm_lookup("l4_per_clkdm");

	l4wkup = clkdm_lookup("l4_wkup_clkdm");

	ducati_clkdm = clkdm_lookup("ducati_clkdm");

	if ((!mpuss_clkdm) || (!emif_clkdm) || (!l3_1_clkdm) || (!l4wkup) ||

	if ((!mpuss_clkdm) || (!emif_clkdm) || (!l3_1_clkdm) ||

		(!l3_2_clkdm) || (!ducati_clkdm) || (!l4_per_clkdm))

		goto err2;
@@ -191,7 +186,6 @@ int __init omap4_pm_init(void) 
	ret |= clkdm_add_wkdep(mpuss_clkdm, l3_1_clkdm);

	ret |= clkdm_add_wkdep(mpuss_clkdm, l3_2_clkdm);

	ret |= clkdm_add_wkdep(mpuss_clkdm, l4_per_clkdm);

	ret |= clkdm_add_wkdep(mpuss_clkdm, l4wkup);

	ret |= clkdm_add_wkdep(ducati_clkdm, l3_1_clkdm);

	ret |= clkdm_add_wkdep(ducati_clkdm, l3_2_clkdm);

	if (ret) {