Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 6ba96dce authored by Vivek Gautam's avatar Vivek Gautam Committed by Greg Kroah-Hartman
Browse files

usb: host: ehci-tegra: Use devm_ioremap_resource instead of devm_ioremap 



Using devm_ioremap_resource() API should actually be preferred over
devm_ioremap(), since the former request the mem region first and then
gives back the ioremap'ed memory pointer.
devm_ioremap_resource() calls request_mem_region(), therby preventing
other drivers to make any overlapping call to the same region.

Signed-off-by: default avatarVivek Gautam <gautam.vivek@samsung.com>
Acked-by: default avatarAlan Stern <stern@rowland.harvard.edu>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent e0f77a91

drivers/usb/host/ehci-tegra.c

+3 −4
Original line number Diff line number Diff line
@@ -411,10 +411,9 @@ static int tegra_ehci_probe(struct platform_device *pdev) 
	}

	hcd->rsrc_start = res->start;

	hcd->rsrc_len = resource_size(res);

	hcd->regs = devm_ioremap(&pdev->dev, res->start, resource_size(res));

	if (!hcd->regs) {

		dev_err(&pdev->dev, "Failed to remap I/O memory\n");

		err = -ENOMEM;

	hcd->regs = devm_ioremap_resource(&pdev->dev, res);

	if (IS_ERR(hcd->regs)) {

		err = PTR_ERR(hcd->regs);

		goto cleanup_clk_en;

	}

	ehci->caps = hcd->regs + 0x100;