Commit e0f77a91 authored May 10, 2014 by Vivek Gautam Committed by Greg Kroah-Hartman May 27, 2014

usb: host: ehci-spear: Use devm_ioremap_resource instead of devm_ioremap



Using devm_ioremap_resource() API should actually be preferred over
devm_ioremap(), since the former request the mem region first and then
gives back the ioremap'ed memory pointer.
devm_ioremap_resource() calls request_mem_region(), therby preventing
other drivers to make any overlapping call to the same region.

Signed-off-by: Vivek Gautam <gautam.vivek@samsung.com>
Acked-by: Alan Stern <stern@rowland.harvard.edu>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>

parent 40a5ec98

drivers/usb/host/ehci-spear.c

+3 −10

Original line number	Diff line number	Diff line
		@@ -106,16 +106,9 @@ static int spear_ehci_hcd_drv_probe(struct platform_device *pdev)

		hcd->rsrc_start = res->start;
		hcd->rsrc_len = resource_size(res);
		if (!devm_request_mem_region(&pdev->dev, hcd->rsrc_start, hcd->rsrc_len,
		driver->description)) {
		retval = -EBUSY;
		goto err_put_hcd;
		}

		hcd->regs = devm_ioremap(&pdev->dev, hcd->rsrc_start, hcd->rsrc_len);
		if (hcd->regs == NULL) {
		dev_dbg(&pdev->dev, "error mapping memory\n");
		retval = -ENOMEM;
		hcd->regs = devm_ioremap_resource(&pdev->dev, res);
		if (IS_ERR(hcd->regs)) {
		retval = PTR_ERR(hcd->regs);
		goto err_put_hcd;
		}