Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 583a2b2c authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Jacek Anaszewski
Browse files

leds: leds-ot200: Use devm_led_classdev_register 



Use resource-managed function devm_led_classdev_register
instead of led_classdev_register to make the error path simpler.
The goto is replaced with direct return, unneeded label err is
dropped. Also, remove redundant ot200_led_remove.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
parent c0fc68ba

drivers/leds/leds-ot200.c

+2 −19
Original line number Diff line number Diff line
@@ -124,9 +124,9 @@ static int ot200_led_probe(struct platform_device *pdev) 
		leds[i].cdev.name = leds[i].name;

		leds[i].cdev.brightness_set = ot200_led_brightness_set;



		ret = led_classdev_register(&pdev->dev, &leds[i].cdev);

		ret = devm_led_classdev_register(&pdev->dev, &leds[i].cdev);

		if (ret < 0)

			goto err;

			return ret;

	}



	leds_front = 0;		/* turn off all front leds */
@@ -135,27 +135,10 @@ static int ot200_led_probe(struct platform_device *pdev) 
	outb(leds_back, 0x5a);



	return 0;



err:

	for (i = i - 1; i >= 0; i--)

		led_classdev_unregister(&leds[i].cdev);



	return ret;

}



static int ot200_led_remove(struct platform_device *pdev)

{

	int i;



	for (i = 0; i < ARRAY_SIZE(leds); i++)

		led_classdev_unregister(&leds[i].cdev);



	return 0;

}



static struct platform_driver ot200_led_driver = {

	.probe		= ot200_led_probe,

	.remove		= ot200_led_remove,

	.driver		= {

		.name	= "leds-ot200",

	},