Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit c0fc68ba authored by Muhammad Falak R Wani's avatar Muhammad Falak R Wani Committed by Jacek Anaszewski
Browse files

leds: leds-hp6xx: Use devm_led_classdev_register 



Use resource-managed function devm_led_classdev_register
instead of led_classdev_register to simplify error path.
An unnecessary check of ret is replaced with a direct return
Also, remove redundant hp6xxled_remove.

Signed-off-by: default avatarMuhammad Falak R Wani <falakreyaz@gmail.com>
Signed-off-by: default avatarJacek Anaszewski <j.anaszewski@samsung.com>
parent aa4e2524

drivers/leds/leds-hp6xx.c

+2 −15
Original line number Diff line number Diff line
@@ -59,28 +59,15 @@ static int hp6xxled_probe(struct platform_device *pdev) 
{

	int ret;



	ret = led_classdev_register(&pdev->dev, &hp6xx_red_led);

	ret = devm_led_classdev_register(&pdev->dev, &hp6xx_red_led);

	if (ret < 0)

		return ret;



	ret = led_classdev_register(&pdev->dev, &hp6xx_green_led);

	if (ret < 0)

		led_classdev_unregister(&hp6xx_red_led);



	return ret;

}



static int hp6xxled_remove(struct platform_device *pdev)

{

	led_classdev_unregister(&hp6xx_red_led);

	led_classdev_unregister(&hp6xx_green_led);



	return 0;

	return devm_led_classdev_register(&pdev->dev, &hp6xx_green_led);

}



static struct platform_driver hp6xxled_driver = {

	.probe		= hp6xxled_probe,

	.remove		= hp6xxled_remove,

	.driver		= {

		.name		= "hp6xx-led",

	},