Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 572e8f3e authored by Amitkumar Karwar's avatar Amitkumar Karwar Committed by John W. Linville
Browse files

mwifiex: remove unused function parameters 



Some function parameters become useless after previous
cleanup changes.

Signed-off-by: default avatarAmitkumar Karwar <akarwar@marvell.com>
Signed-off-by: default avatarBing Zhao <bzhao@marvell.com>
Signed-off-by: default avatarJohn W. Linville <linville@tuxdriver.com>
parent 19a89860

drivers/net/wireless/mwifiex/11n.c

+4 −9
Original line number Original line Diff line number Diff line
@@ -242,9 +242,7 @@ int mwifiex_ret_11n_addba_req(struct mwifiex_private *priv, 
 *

 *

 * Handling includes changing the header fields into CPU format.

 * Handling includes changing the header fields into CPU format.

 */

 */

int mwifiex_ret_11n_cfg(struct mwifiex_private *priv,

int mwifiex_ret_11n_cfg(struct host_cmd_ds_command *resp, void *data_buf)

			struct host_cmd_ds_command *resp,

			void *data_buf)

{

{

	struct mwifiex_ds_11n_tx_cfg *tx_cfg = NULL;

	struct mwifiex_ds_11n_tx_cfg *tx_cfg = NULL;

	struct host_cmd_ds_11n_cfg *htcfg = &resp->params.htcfg;

	struct host_cmd_ds_11n_cfg *htcfg = &resp->params.htcfg;
@@ -298,8 +296,7 @@ int mwifiex_cmd_recfg_tx_buf(struct mwifiex_private *priv, 
 *      - Setting AMSDU control parameters (for SET only)

 *      - Setting AMSDU control parameters (for SET only)

 *      - Ensuring correct endian-ness

 *      - Ensuring correct endian-ness

 */

 */

int mwifiex_cmd_amsdu_aggr_ctrl(struct mwifiex_private *priv,

int mwifiex_cmd_amsdu_aggr_ctrl(struct host_cmd_ds_command *cmd,

				struct host_cmd_ds_command *cmd,

				int cmd_action, void *data_buf)

				int cmd_action, void *data_buf)

{

{

	struct host_cmd_ds_amsdu_aggr_ctrl *amsdu_ctrl =

	struct host_cmd_ds_amsdu_aggr_ctrl *amsdu_ctrl =
@@ -331,8 +328,7 @@ int mwifiex_cmd_amsdu_aggr_ctrl(struct mwifiex_private *priv, 
 *

 *

 * Handling includes changing the header fields into CPU format.

 * Handling includes changing the header fields into CPU format.

 */

 */

int mwifiex_ret_amsdu_aggr_ctrl(struct mwifiex_private *priv,

int mwifiex_ret_amsdu_aggr_ctrl(struct host_cmd_ds_command *resp,

				struct host_cmd_ds_command *resp,

				void *data_buf)

				void *data_buf)

{

{

	struct mwifiex_ds_11n_amsdu_aggr_ctrl *amsdu_aggr_ctrl = NULL;

	struct mwifiex_ds_11n_amsdu_aggr_ctrl *amsdu_aggr_ctrl = NULL;
@@ -357,8 +353,7 @@ int mwifiex_ret_amsdu_aggr_ctrl(struct mwifiex_private *priv, 
 *      - Setting HT Tx capability and HT Tx information fields

 *      - Setting HT Tx capability and HT Tx information fields

 *      - Ensuring correct endian-ness

 *      - Ensuring correct endian-ness

 */

 */

int mwifiex_cmd_11n_cfg(struct mwifiex_private *priv,

int mwifiex_cmd_11n_cfg(struct host_cmd_ds_command *cmd,

			struct host_cmd_ds_command *cmd,

			u16 cmd_action, void *data_buf)

			u16 cmd_action, void *data_buf)

{

{

	struct host_cmd_ds_11n_cfg *htcfg = &cmd->params.htcfg;

	struct host_cmd_ds_11n_cfg *htcfg = &cmd->params.htcfg;

drivers/net/wireless/mwifiex/11n.h

+17 −33
Original line number Original line Diff line number Diff line
@@ -28,15 +28,9 @@ int mwifiex_ret_11n_delba(struct mwifiex_private *priv, 
			  struct host_cmd_ds_command *resp);

			  struct host_cmd_ds_command *resp);

int mwifiex_ret_11n_addba_req(struct mwifiex_private *priv,

int mwifiex_ret_11n_addba_req(struct mwifiex_private *priv,

			      struct host_cmd_ds_command *resp);

			      struct host_cmd_ds_command *resp);

int mwifiex_ret_11n_cfg(struct mwifiex_private *priv,

int mwifiex_ret_11n_cfg(struct host_cmd_ds_command *resp,

			struct host_cmd_ds_command *resp,

			void *data_buf);

			void *data_buf);

int mwifiex_cmd_11n_cfg(struct mwifiex_private *priv,

int mwifiex_cmd_11n_cfg(struct host_cmd_ds_command *cmd,

			struct host_cmd_ds_command *cmd,

			u16 cmd_action, void *data_buf);



int mwifiex_cmd_11n_cfg(struct mwifiex_private *priv,

			struct host_cmd_ds_command *cmd,

			u16 cmd_action, void *data_buf);

			u16 cmd_action, void *data_buf);





int mwifiex_cmd_append_11n_tlv(struct mwifiex_private *priv,

int mwifiex_cmd_append_11n_tlv(struct mwifiex_private *priv,
@@ -67,24 +61,19 @@ int mwifiex_get_rx_reorder_tbl(struct mwifiex_private *priv, 
			      struct mwifiex_ds_rx_reorder_tbl *buf);

			      struct mwifiex_ds_rx_reorder_tbl *buf);

int mwifiex_get_tx_ba_stream_tbl(struct mwifiex_private *priv,

int mwifiex_get_tx_ba_stream_tbl(struct mwifiex_private *priv,

			       struct mwifiex_ds_tx_ba_stream_tbl *buf);

			       struct mwifiex_ds_tx_ba_stream_tbl *buf);

int mwifiex_ret_amsdu_aggr_ctrl(struct mwifiex_private *priv,

int mwifiex_ret_amsdu_aggr_ctrl(struct host_cmd_ds_command *resp,

				struct host_cmd_ds_command

				*resp,

				void *data_buf);

				void *data_buf);

int mwifiex_cmd_recfg_tx_buf(struct mwifiex_private *priv,

int mwifiex_cmd_recfg_tx_buf(struct mwifiex_private *priv,

			     struct host_cmd_ds_command *cmd,

			     struct host_cmd_ds_command *cmd,

			     int cmd_action, void *data_buf);

			     int cmd_action, void *data_buf);

int mwifiex_cmd_amsdu_aggr_ctrl(struct mwifiex_private *priv,

int mwifiex_cmd_amsdu_aggr_ctrl(struct host_cmd_ds_command *cmd,

				struct host_cmd_ds_command *cmd,

				int cmd_action, void *data_buf);

				int cmd_action,

				void *data_buf);





/*

/*

 * This function checks whether AMPDU is allowed or not for a particular TID.

 * This function checks whether AMPDU is allowed or not for a particular TID.

 */

 */

static inline u8

static inline u8

mwifiex_is_ampdu_allowed(struct mwifiex_private *priv,

mwifiex_is_ampdu_allowed(struct mwifiex_private *priv, int tid)

			 struct mwifiex_ra_list_tbl *ptr, int tid)

{

{

	return ((priv->aggr_prio_tbl[tid].ampdu_ap != BA_STREAM_NOT_ALLOWED)

	return ((priv->aggr_prio_tbl[tid].ampdu_ap != BA_STREAM_NOT_ALLOWED)

		? true : false);

		? true : false);
@@ -94,8 +83,7 @@ mwifiex_is_ampdu_allowed(struct mwifiex_private *priv, 
 * This function checks whether AMSDU is allowed or not for a particular TID.

 * This function checks whether AMSDU is allowed or not for a particular TID.

 */

 */

static inline u8

static inline u8

mwifiex_is_amsdu_allowed(struct mwifiex_private *priv,

mwifiex_is_amsdu_allowed(struct mwifiex_private *priv, int tid)

			 struct mwifiex_ra_list_tbl *ptr, int tid)

{

{

	return (((priv->aggr_prio_tbl[tid].amsdu != BA_STREAM_NOT_ALLOWED)

	return (((priv->aggr_prio_tbl[tid].amsdu != BA_STREAM_NOT_ALLOWED)

			&& ((priv->is_data_rate_auto)

			&& ((priv->is_data_rate_auto)
@@ -106,21 +94,18 @@ mwifiex_is_amsdu_allowed(struct mwifiex_private *priv, 
/*

/*

 * This function checks whether a BA stream is available or not.

 * This function checks whether a BA stream is available or not.

 */

 */

static inline u8

static inline u8 mwifiex_is_ba_stream_avail(struct mwifiex_adapter *adapter)

mwifiex_is_ba_stream_avail(struct mwifiex_private *priv)

{

{

	struct mwifiex_private *pmpriv = NULL;

	struct mwifiex_private *priv;

	u8 i = 0;

	u8 i;

	u32 ba_stream_num = 0;

	u32 ba_stream_num = 0;





	for (i = 0; i < priv->adapter->priv_num; i++) {

	for (i = 0; i < adapter->priv_num; i++) {

		pmpriv = priv->adapter->priv[i];

		priv = adapter->priv[i];

		if (pmpriv)

		if (priv)

			ba_stream_num +=

			ba_stream_num += mwifiex_wmm_list_len(

				mwifiex_wmm_list_len(priv->adapter,

						(struct list_head *)

						     (struct list_head

						&priv->tx_ba_stream_tbl_ptr);

						      *) &pmpriv->

						     tx_ba_stream_tbl_ptr);

	}

	}





	return ((ba_stream_num <

	return ((ba_stream_num <
@@ -133,8 +118,7 @@ mwifiex_is_ba_stream_avail(struct mwifiex_private *priv) 
 * Upon successfully locating, both the TID and the RA are returned.

 * Upon successfully locating, both the TID and the RA are returned.

 */

 */

static inline u8

static inline u8

mwifiex_find_stream_to_delete(struct mwifiex_private *priv,

mwifiex_find_stream_to_delete(struct mwifiex_private *priv, int ptr_tid,

			      struct mwifiex_ra_list_tbl *ptr, int ptr_tid,

			      int *ptid, u8 *ra)

			      int *ptid, u8 *ra)

{

{

	int tid;

	int tid;

drivers/net/wireless/mwifiex/11n_aggr.c

+2 −3
Original line number Original line Diff line number Diff line
@@ -44,8 +44,7 @@ 
 * MSDU => |DA|SA|Length|SNAP|......   ..|

 * MSDU => |DA|SA|Length|SNAP|......   ..|

 */

 */

static int

static int

mwifiex_11n_form_amsdu_pkt(struct mwifiex_adapter *adapter,

mwifiex_11n_form_amsdu_pkt(struct sk_buff *skb_aggr,

			   struct sk_buff *skb_aggr,

			   struct sk_buff *skb_src, int *pad)

			   struct sk_buff *skb_src, int *pad)





{

{
@@ -324,7 +323,7 @@ mwifiex_11n_aggregate_pkt(struct mwifiex_private *priv, 




		spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,

		spin_unlock_irqrestore(&priv->wmm.ra_list_spinlock,

				       ra_list_flags);

				       ra_list_flags);

		mwifiex_11n_form_amsdu_pkt(adapter, skb_aggr, skb_src, &pad);

		mwifiex_11n_form_amsdu_pkt(skb_aggr, skb_src, &pad);





		mwifiex_write_data_complete(adapter, skb_src, 0);

		mwifiex_write_data_complete(adapter, skb_src, 0);

drivers/net/wireless/mwifiex/11n_rxreorder.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -319,8 +319,7 @@ mwifiex_11n_create_rx_reorder_tbl(struct mwifiex_private *priv, u8 *ta, 
 *      - Setting add BA request buffer

 *      - Setting add BA request buffer

 *      - Ensuring correct endian-ness

 *      - Ensuring correct endian-ness

 */

 */

int mwifiex_cmd_11n_addba_req(struct mwifiex_private *priv,

int mwifiex_cmd_11n_addba_req(struct host_cmd_ds_command *cmd, void *data_buf)

			      struct host_cmd_ds_command *cmd, void *data_buf)

{

{

	struct host_cmd_ds_11n_addba_req *add_ba_req =

	struct host_cmd_ds_11n_addba_req *add_ba_req =

		(struct host_cmd_ds_11n_addba_req *)

		(struct host_cmd_ds_11n_addba_req *)
@@ -391,8 +390,7 @@ int mwifiex_cmd_11n_addba_rsp_gen(struct mwifiex_private *priv, 
 *      - Setting del BA request buffer

 *      - Setting del BA request buffer

 *      - Ensuring correct endian-ness

 *      - Ensuring correct endian-ness

 */

 */

int mwifiex_cmd_11n_delba(struct mwifiex_private *priv,

int mwifiex_cmd_11n_delba(struct host_cmd_ds_command *cmd, void *data_buf)

			  struct host_cmd_ds_command *cmd, void *data_buf)

{

{

	struct host_cmd_ds_11n_delba *del_ba = (struct host_cmd_ds_11n_delba *)

	struct host_cmd_ds_11n_delba *del_ba = (struct host_cmd_ds_11n_delba *)

		&cmd->params.del_ba;

		&cmd->params.del_ba;

drivers/net/wireless/mwifiex/11n_rxreorder.h

+2 −4
Original line number Original line Diff line number Diff line
@@ -49,14 +49,12 @@ void mwifiex_11n_ba_stream_timeout(struct mwifiex_private *priv, 
int mwifiex_ret_11n_addba_resp(struct mwifiex_private *priv,

int mwifiex_ret_11n_addba_resp(struct mwifiex_private *priv,

			       struct host_cmd_ds_command

			       struct host_cmd_ds_command

			       *resp);

			       *resp);

int mwifiex_cmd_11n_delba(struct mwifiex_private *priv,

int mwifiex_cmd_11n_delba(struct host_cmd_ds_command *cmd,

			  struct host_cmd_ds_command *cmd,

			  void *data_buf);

			  void *data_buf);

int mwifiex_cmd_11n_addba_rsp_gen(struct mwifiex_private *priv,

int mwifiex_cmd_11n_addba_rsp_gen(struct mwifiex_private *priv,

				  struct host_cmd_ds_command

				  struct host_cmd_ds_command

				  *cmd, void *data_buf);

				  *cmd, void *data_buf);

int mwifiex_cmd_11n_addba_req(struct mwifiex_private *priv,

int mwifiex_cmd_11n_addba_req(struct host_cmd_ds_command *cmd,

			      struct host_cmd_ds_command *cmd,

			      void *data_buf);

			      void *data_buf);

void mwifiex_11n_cleanup_reorder_tbl(struct mwifiex_private *priv);

void mwifiex_11n_cleanup_reorder_tbl(struct mwifiex_private *priv);

struct mwifiex_rx_reorder_tbl *mwifiex_11n_get_rxreorder_tbl(struct

struct mwifiex_rx_reorder_tbl *mwifiex_11n_get_rxreorder_tbl(struct