Commit 55bb1d83 authored Jan 25, 2016 by Amitoj Kaur Chawla Committed by Thierry Reding Jun 14, 2016

memory: tegra: mc: Add missing of_node_put()



for_each_child_of_node() performs an of_node_get() on each iteration, so
to break out of the loop an of_node_put() is required.

Found using Coccinelle. The semantic patch used for this is as follows:

// <smpl>
@@
expression e;
local idexpression n;
@@

 for_each_child_of_node(..., n) {
   ... when != of_node_put(n)
       when != e = n
(
   return n;
|
+  of_node_put(n);
?  return ...;
)
   ...
 }
// </smpl>

Signed-off-by: Amitoj Kaur Chawla <amitoj1606@gmail.com>
Signed-off-by: Thierry Reding <treding@nvidia.com>

parent d1122e4b

drivers/memory/tegra/mc.c

+4 −2

Original line number	Diff line number	Diff line
		@@ -186,9 +186,11 @@ static int load_timings(struct tegra_mc mc, struct device_node node)
		timing = &mc->timings[i++];

		err = load_one_timing(mc, timing, child);
		if (err)
		if (err) {
		of_node_put(child);
		return err;
		}
		}

		return 0;
		}
		@@ -210,9 +212,9 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc)
		continue;

		err = load_timings(mc, node);
		of_node_put(node);
		if (err)
		return err;
		of_node_put(node);
		break;
		}