Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d1122e4b authored by Julia Lawall's avatar Julia Lawall Committed by Thierry Reding
Browse files

memory: tegra: Delete unneeded of_node_put() 

for_each_child_of_node() performs an of_node_put() on each iteration, so
putting an of_node_put() before a continue results in a double put.

The semantic match that finds this problem is as follows
(http://coccinelle.lip6.fr

):

// <smpl>
@@
expression root,e;
local idexpression child;
iterator name for_each_child_of_node;
@@

 for_each_child_of_node(root, child) {
   ... when != of_node_get(child)
*  of_node_put(child);
   ...
*  continue;
}
// </smpl>

Signed-off-by: default avatarJulia Lawall <Julia.Lawall@lip6.fr>
Signed-off-by: default avatarThierry Reding <treding@nvidia.com>
parent aafb197f

drivers/memory/tegra/mc.c

+1 −3
Original line number Diff line number Diff line
@@ -206,10 +206,8 @@ static int tegra_mc_setup_timings(struct tegra_mc *mc) 
	for_each_child_of_node(mc->dev->of_node, node) {

		err = of_property_read_u32(node, "nvidia,ram-code",

					   &node_ram_code);

		if (err || (node_ram_code != ram_code)) {

			of_node_put(node);

		if (err || (node_ram_code != ram_code))

			continue;

		}



		err = load_timings(mc, node);

		if (err)

drivers/memory/tegra/tegra124-emc.c

+1 −3
Original line number Diff line number Diff line
@@ -997,10 +997,8 @@ tegra_emc_find_node_by_ram_code(struct device_node *node, u32 ram_code) 
		u32 value;



		err = of_property_read_u32(np, "nvidia,ram-code", &value);

		if (err || (value != ram_code)) {

			of_node_put(np);

		if (err || (value != ram_code))

			continue;

		}



		return np;

	}