Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 4c048af7 authored by Dan Carpenter's avatar Dan Carpenter Committed by Herbert Xu
Browse files

crypto: mxc-scc - fix unwinding in mxc_scc_crypto_register() 



There are two issues here:

1) We need to decrement "i" otherwise we unregister something that was
   not successfully registered.
2) The original code did not unregister the first element in the array
   where i is zero.

Fixes: d293b640 ('crypto: mxc-scc - add basic driver for the MXC SCC')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent b908bd3d

drivers/crypto/mxc-scc.c

+2 −2
Original line number Diff line number Diff line
@@ -616,7 +616,7 @@ static struct mxc_scc_crypto_tmpl *scc_crypto_algs[] = { 


static int mxc_scc_crypto_register(struct mxc_scc *scc)

{

	unsigned int i;

	int i;

	int err = 0;



	for (i = 0; i < ARRAY_SIZE(scc_crypto_algs); i++) {
@@ -629,7 +629,7 @@ static int mxc_scc_crypto_register(struct mxc_scc *scc) 
	return 0;



err_out:

	for (; i > 0; i--)

	while (--i >= 0)

		crypto_unregister_alg(&scc_crypto_algs[i]->alg);



	return err;