Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit b908bd3d authored by Dan Carpenter's avatar Dan Carpenter Committed by Herbert Xu
Browse files

crypto: mxc-scc - signedness bugs in mxc_scc_ablkcipher_req_init() 



->src_nents and ->dst_nents are unsigned so they can't be less than
zero.  I fixed this by introducing a temporary "nents" variable.

Fixes: d293b640 ('crypto: mxc-scc - add basic driver for the MXC SCC')
Signed-off-by: default avatarDan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: default avatarHerbert Xu <herbert@gondor.apana.org.au>
parent 3639ca84

drivers/crypto/mxc-scc.c

+9 −6
Original line number Diff line number Diff line
@@ -210,18 +210,21 @@ static int mxc_scc_ablkcipher_req_init(struct ablkcipher_request *req, 
				       struct mxc_scc_ctx *ctx)

{

	struct mxc_scc *scc = ctx->scc;

	int nents;



	ctx->src_nents = sg_nents_for_len(req->src, req->nbytes);

	if (ctx->src_nents < 0) {

	nents = sg_nents_for_len(req->src, req->nbytes);

	if (nents < 0) {

		dev_err(scc->dev, "Invalid number of src SC");

		return ctx->src_nents;

		return nents;

	}

	ctx->src_nents = nents;



	ctx->dst_nents = sg_nents_for_len(req->dst, req->nbytes);

	if (ctx->dst_nents < 0) {

	nents = sg_nents_for_len(req->dst, req->nbytes);

	if (nents < 0) {

		dev_err(scc->dev, "Invalid number of dst SC");

		return ctx->dst_nents;

		return nents;

	}

	ctx->dst_nents = nents;



	ctx->size = 0;

	ctx->offset = 0;