Commit 4802f224 authored Jul 03, 2013 by Jingoo Han Committed by Linus Torvalds Jul 03, 2013

rtc: rtc-max8998: remove unnecessary platform_set_drvdata()



The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: Jingoo Han <jg1.han@samsung.com>
Signed-off-by: Andrew Morton <akpm@linux-foundation.org>
Signed-off-by: Linus Torvalds <torvalds@linux-foundation.org>

parent 28e1de09

drivers/rtc/rtc-max8998.c

+1 −5

Original line number	Diff line number	Diff line
		@@ -274,7 +274,7 @@ static int max8998_rtc_probe(struct platform_device *pdev)
		if (IS_ERR(info->rtc_dev)) {
		ret = PTR_ERR(info->rtc_dev);
		dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);
		goto out_rtc;
		return ret;
		}

		ret = devm_request_threaded_irq(&pdev->dev, info->irq, NULL,
		@@ -292,10 +292,6 @@ static int max8998_rtc_probe(struct platform_device *pdev)
		}

		return 0;

		out_rtc:
		platform_set_drvdata(pdev, NULL);
		return ret;
		}

		static int max8998_rtc_remove(struct platform_device *pdev)