Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 28e1de09 authored by Jingoo Han's avatar Jingoo Han Committed by Linus Torvalds
Browse files

rtc: rtc-max8925: remove unnecessary platform_set_drvdata() 



The driver core clears the driver data to NULL after device_release or
on probe failure, since commit 0998d063 ("device-core: Ensure drvdata
= NULL when no driver is bound").  Thus, it is not needed to manually
clear the device driver data to NULL.

Signed-off-by: default avatarJingoo Han <jg1.han@samsung.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarLinus Torvalds <torvalds@linux-foundation.org>
parent 5f371582

drivers/rtc/rtc-max8925.c

+2 −5
Original line number Diff line number Diff line
@@ -268,7 +268,7 @@ static int max8925_rtc_probe(struct platform_device *pdev) 
	if (ret < 0) {

		dev_err(chip->dev, "Failed to request IRQ: #%d: %d\n",

			info->irq, ret);

		goto err;

		return ret;

	}



	dev_set_drvdata(&pdev->dev, info);
@@ -282,13 +282,10 @@ static int max8925_rtc_probe(struct platform_device *pdev) 
	ret = PTR_ERR(info->rtc_dev);

	if (IS_ERR(info->rtc_dev)) {

		dev_err(&pdev->dev, "Failed to register RTC device: %d\n", ret);

		goto err;

		return ret;

	}



	return 0;

err:

	platform_set_drvdata(pdev, NULL);

	return ret;

}



static int max8925_rtc_remove(struct platform_device *pdev)