perf session: Fix infinite loop in __perf_session__process_events
In this if statement:
        if (head + event->header.size >= mmap_size) {
                if (mmaps[map_idx]) {
                        munmap(mmaps[map_idx], mmap_size);
                        mmaps[map_idx] = NULL;
                }
                page_offset = page_size * (head / page_size);
                file_offset += page_offset;
                head -= page_offset;
                goto remap;
        }
With, for instance, these values:
head=2992
event->header.size=48
mmap_size=3040
We end up endlessly looping back to remap. Off by one.
Problem introduced in 55b44629.
Reported-by:  Linus Torvalds <torvalds@linux-foundation.org>
Reported-by:
Linus Torvalds <torvalds@linux-foundation.org>
Reported-by:  Ingo Molnar <mingo@elte.hu>
Reported-by:
Ingo Molnar <mingo@elte.hu>
Reported-by:  David Ahern <daahern@cisco.com>
Bisected-by:
David Ahern <daahern@cisco.com>
Bisected-by:  David Ahern <daahern@cisco.com>
Tested-by:
David Ahern <daahern@cisco.com>
Tested-by:  David Ahern <daahern@cisco.com>
Cc: David Ahern <daahern@cisco.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by:
David Ahern <daahern@cisco.com>
Cc: David Ahern <daahern@cisco.com>
Cc: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Paul Mackerras <paulus@samba.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Stephane Eranian <eranian@google.com>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Tom Zanussi <tzanussi@gmail.com>
LKML-Reference: <new-submission>
Signed-off-by:  Arnaldo Carvalho de Melo <acme@redhat.com>
Arnaldo Carvalho de Melo <acme@redhat.com>
Loading
Please register or sign in to comment
