Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 3bf460f7 authored by Axel Lin's avatar Axel Lin Committed by Matthew Garrett
Browse files

asus_acpi: fix coding style to improve readability 



In the case of no match ( hotk->model == END_MODEL ), the only posible
case to return 0 is to have a Samsung P30 detected.  This patch improves
readability by moving related code after if/else clause to be inside if
clause.

Signed-off-by: default avatarAxel Lin <axel.lin@gmail.com>
Cc: Corentin Chary <corentincj@iksaif.net>
Cc: Karol Kozimor <sziwan@users.sourceforge.net>
Cc: Matthew Garrett <mjg@redhat.com>
Cc: Len Brown <len.brown@intel.com>
Signed-off-by: default avatarAndrew Morton <akpm@linux-foundation.org>
Signed-off-by: default avatarMatthew Garrett <mjg@redhat.com>
parent d47bb5b2

drivers/platform/x86/asus_acpi.c

+3 −3
Original line number Original line Diff line number Diff line
@@ -1330,6 +1330,9 @@ static int asus_hotk_get_info(void) 
			hotk->model = P30;

			hotk->model = P30;

			printk(KERN_NOTICE

			printk(KERN_NOTICE

			       "  Samsung P30 detected, supported\n");

			       "  Samsung P30 detected, supported\n");

			hotk->methods = &model_conf[hotk->model];

			kfree(model);

			return 0;

		} else {

		} else {

			hotk->model = M2E;

			hotk->model = M2E;

			printk(KERN_NOTICE "  unsupported model %s, trying "

			printk(KERN_NOTICE "  unsupported model %s, trying "
@@ -1339,9 +1342,6 @@ static int asus_hotk_get_info(void) 
			kfree(model);

			kfree(model);

			return -ENODEV;

			return -ENODEV;

		}

		}

		hotk->methods = &model_conf[hotk->model];

		kfree(model);

		return 0;

	}

	}

	hotk->methods = &model_conf[hotk->model];

	hotk->methods = &model_conf[hotk->model];

	printk(KERN_NOTICE "  %s model detected, supported\n", string);

	printk(KERN_NOTICE "  %s model detected, supported\n", string);