Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 34a9b81b authored by Nikith Ganigarakoppal's avatar Nikith Ganigarakoppal Committed by James Bottomley
Browse files

[SCSI] pm80xx: Fix for direct attached device. 



In case of direct attached SATA device delay is not enough.
It will give crash for set device state command response and
wait_for_completion is the best solution for this.

Signed-off-by: default avatar <Nikith.Ganigarakoppal@pmcs.com>
Signed-off-by: default avatar <Anandkumar.Santhanam@pmcs.com>
Reviewed-by: default avatarJack Wang <jinpu.wang@profitbricks.com>
Signed-off-by: default avatarJames Bottomley <JBottomley@Parallels.com>
parent 94f33c16

drivers/scsi/pm8001/pm8001_sas.c

+3 −1
Original line number Diff line number Diff line
@@ -1098,15 +1098,17 @@ int pm8001_lu_reset(struct domain_device *dev, u8 *lun) 
	struct pm8001_tmf_task tmf_task;

	struct pm8001_device *pm8001_dev = dev->lldd_dev;

	struct pm8001_hba_info *pm8001_ha = pm8001_find_ha_by_dev(dev);

	DECLARE_COMPLETION_ONSTACK(completion_setstate);

	if (dev_is_sata(dev)) {

		struct sas_phy *phy = sas_get_local_phy(dev);

		rc = pm8001_exec_internal_task_abort(pm8001_ha, pm8001_dev ,

			dev, 1, 0);

		rc = sas_phy_reset(phy, 1);

		sas_put_local_phy(phy);

		pm8001_dev->setds_completion = &completion_setstate;

		rc = PM8001_CHIP_DISP->set_dev_state_req(pm8001_ha,

			pm8001_dev, 0x01);

		msleep(2000);

		wait_for_completion(&completion_setstate);

	} else {

		tmf_task.tmf = TMF_LU_RESET;

		rc = pm8001_issue_ssp_tmf(dev, lun, &tmf_task);