Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 1ae39a43 authored by Patrick McHardy's avatar Patrick McHardy Committed by David S. Miller
Browse files

[NET_SCHED]: cls_u32: remove unnecessary NULL-ptr check 



In both cases n can't be NULL without crashing anyway.

Coverity #78

Signed-off-by: default avatarPatrick McHardy <kaber@trash.net>
Signed-off-by: default avatarDavid S. Miller <davem@davemloft.net>
parent a5cdc030

net/sched/cls_u32.c

+2 −4
Original line number Original line Diff line number Diff line
@@ -347,7 +347,6 @@ static int u32_destroy_key(struct tcf_proto *tp, struct tc_u_knode *n) 
	if (n->ht_down)

	if (n->ht_down)

		n->ht_down->refcnt--;

		n->ht_down->refcnt--;

#ifdef CONFIG_CLS_U32_PERF

#ifdef CONFIG_CLS_U32_PERF

	if (n)

	kfree(n->pf);

	kfree(n->pf);

#endif

#endif

	kfree(n);

	kfree(n);
@@ -680,7 +679,6 @@ static int u32_change(struct tcf_proto *tp, unsigned long base, u32 handle, 
		return 0;

		return 0;

	}

	}

#ifdef CONFIG_CLS_U32_PERF

#ifdef CONFIG_CLS_U32_PERF

	if (n)

	kfree(n->pf);

	kfree(n->pf);

#endif

#endif

	kfree(n);

	kfree(n);