Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 0d44975d authored by Denys Vlasenko's avatar Denys Vlasenko Committed by Ingo Molnar
Browse files

x86/kgdb: Replace bool_int_array[NR_CPUS] with bitmap 



Straigntforward conversion from:

    int was_in_debug_nmi[NR_CPUS]

to:

    DECLARE_BITMAP(was_in_debug_nmi, NR_CPUS)

Saves about 2 kbytes in BSS for NR_CPUS=512.

Signed-off-by: default avatarDenys Vlasenko <dvlasenk@redhat.com>
Cc: H. Peter Anvin <hpa@zytor.com>
Cc: Jason Wessel <jason.wessel@windriver.com>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: linux-kernel@vger.kernel.org
Link: http://lkml.kernel.org/r/1443271638-2568-1-git-send-email-dvlasenk@redhat.com


[ Tidied up the code a bit. ]
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
parent 097f70b3

arch/x86/kernel/kgdb.c

+11 −6
Original line number Diff line number Diff line
@@ -511,26 +511,31 @@ single_step_cont(struct pt_regs *regs, struct die_args *args) 
	return NOTIFY_STOP;

}



static int was_in_debug_nmi[NR_CPUS];

static DECLARE_BITMAP(was_in_debug_nmi, NR_CPUS);



static int kgdb_nmi_handler(unsigned int cmd, struct pt_regs *regs)

{

	int cpu;



	switch (cmd) {

	case NMI_LOCAL:

		if (atomic_read(&kgdb_active) != -1) {

			/* KGDB CPU roundup */

			kgdb_nmicallback(raw_smp_processor_id(), regs);

			was_in_debug_nmi[raw_smp_processor_id()] = 1;

			cpu = raw_smp_processor_id();

			kgdb_nmicallback(cpu, regs);

			set_bit(cpu, was_in_debug_nmi);

			touch_nmi_watchdog();



			return NMI_HANDLED;

		}

		break;



	case NMI_UNKNOWN:

		if (was_in_debug_nmi[raw_smp_processor_id()]) {

			was_in_debug_nmi[raw_smp_processor_id()] = 0;

		cpu = raw_smp_processor_id();



		if (__test_and_clear_bit(cpu, was_in_debug_nmi))

			return NMI_HANDLED;

		}



		break;

	default:

		/* do nothing */