Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit fdc84d11 authored by Joern Engel's avatar Joern Engel Committed by Nicholas Bellinger
Browse files

iscsi-target: use strlcpy in iscsit_collect_login_stats 



last_intr_fail_name is a fixed-size array and could theoretically
overflow.  In reality intrname->value doesn't seem to depend on
untrusted input or be anywhere near 224 characters, so the overflow is
pretty theoretical.  But strlcpy is cheap enough.

Found by coverity.

Signed-off-by: default avatarJoern Engel <joern@logfs.org>
Signed-off-by: default avatarNicholas Bellinger <nab@linux-iscsi.org>
parent 94e16e9c

drivers/target/iscsi/iscsi_target_util.c

+3 −2
Original line number Diff line number Diff line
@@ -1479,8 +1479,9 @@ void iscsit_collect_login_stats( 
		if (conn->param_list)

			intrname = iscsi_find_param_from_key(INITIATORNAME,

							     conn->param_list);

		strcpy(ls->last_intr_fail_name,

		       (intrname ? intrname->value : "Unknown"));

		strlcpy(ls->last_intr_fail_name,

		       (intrname ? intrname->value : "Unknown"),

		       sizeof(ls->last_intr_fail_name));



		ls->last_intr_fail_ip_family = conn->login_family;