Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit f46187d1 authored by Michael S. Tsirkin's avatar Michael S. Tsirkin Committed by Alistair Strachan
Browse files

UPSTREAM: vhost: fix info leak due to uninitialized memory



commit 670ae9caaca467ea1bfd325cb2a5c98ba87f94ad upstream.

struct vhost_msg within struct vhost_msg_node is copied to userspace.
Unfortunately it turns out on 64 bit systems vhost_msg has padding after
type which gcc doesn't initialize, leaking 4 uninitialized bytes to
userspace.

This padding also unfortunately means 32 bit users of this interface are
broken on a 64 bit kernel which will need to be fixed separately.

Fixes: CVE-2018-1118
Cc: stable@vger.kernel.org
Reported-by: default avatarKevin Easton <kevin@guarana.org>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Reported-by: default avatar <syzbot+87cfa083e727a224754b@syzkaller.appspotmail.com>
Signed-off-by: default avatarMichael S. Tsirkin <mst@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
(cherry picked from commit 9681c3bdb098f6c87a0422b6b63912c1b90ad197)
Bug: 121166534
Test: Ran cuttlefish with android-4.4 + VSOCKETS, VMWARE_VMCI_VSOCKETS
Signed-off-by: default avatarAlistair Strachan <astrachan@google.com>

Change-Id: Ie5a29c3946792ae0f20e04015ba28c89fd90becb
parent 6619733e
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment