Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

This project is archived. Its data is read-only.

Commit da94c13a authored Jan 02, 2018 by Marc Zyngier Committed by Greg Hackmann Jan 18, 2018

FROMLIST: arm64: Move post_ttbr_update_workaround to C code



We will soon need to invoke a CPU-specific function pointer after changing
page tables, so move post_ttbr_update_workaround out into C code to make
this possible.

Signed-off-by: Marc Zyngier <marc.zyngier@arm.com>
Signed-off-by: Will Deacon <will.deacon@arm.com>
(cherry picked from git://git.kernel.org/pub/scm/linux/kernel/git/arm64/linux.git


 commit 400a169447ad2268b023637a118fba27246bcc19)

Change-Id: I4e6edb3dcb6aabe9c17e4698619a093e76495b36
Signed-off-by: Greg Hackmann <ghackmann@google.com>

parent c30184d9

arch/arm64/include/asm/assembler.h

+0 −13

Original line number	Diff line number	Diff line
		@@ -398,17 +398,4 @@ alternative_endif
		mrs \rd, sp_el0
		.endm

		/*
		* Errata workaround post TTBRx_EL1 update.
		*/
		.macro post_ttbr_update_workaround
		#ifdef CONFIG_CAVIUM_ERRATUM_27456
		alternative_if ARM64_WORKAROUND_CAVIUM_27456
		ic iallu
		dsb nsh
		isb
		alternative_else_nop_endif
		#endif
		.endm

		#endif /* __ASM_ASSEMBLER_H */

arch/arm64/kernel/entry.S

+1 −1

Original line number	Diff line number	Diff line
		@@ -241,7 +241,7 @@ alternative_else_nop_endif
		* Cavium erratum 27456 (broadcast TLBI instructions may cause I-cache
		* corruption).
		*/
		post_ttbr_update_workaround
		bl post_ttbr_update_workaround
		.endif
		1:
		.if \el != 0

arch/arm64/mm/context.c

+9 −0

Original line number	Diff line number	Diff line
		@@ -199,6 +199,15 @@ switch_mm_fastpath:
		cpu_switch_mm(mm->pgd, mm);
		}

		/* Errata workaround post TTBRx_EL1 update. */
		asmlinkage void post_ttbr_update_workaround(void)
		{
		asm(ALTERNATIVE("nop; nop; nop",
		"ic iallu; dsb nsh; isb",
		ARM64_WORKAROUND_CAVIUM_27456,
		CONFIG_CAVIUM_ERRATUM_27456));
		}

		static int asids_init(void)
		{
		int fld = cpuid_feature_extract_field(read_cpuid(SYS_ID_AA64MMFR0_EL1), 4);

arch/arm64/mm/proc.S

+1 −2

Original line number	Diff line number	Diff line
		@@ -145,8 +145,7 @@ ENTRY(cpu_do_switch_mm)
		isb
		msr ttbr0_el1, x0 // now update TTBR0
		isb
		post_ttbr_update_workaround
		ret
		b post_ttbr_update_workaround // Back to C code...
		ENDPROC(cpu_do_switch_mm)

		.pushsection ".idmap.text", "ax"