Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit d8f4633d authored by Steve French's avatar Steve French Committed by Greg Kroah-Hartman
Browse files

Cleanup missing frees on some ioctls 



commit 24df1483c272c99ed88b0cba135d0e1dfdee3930 upstream.

Cleanup some missing mem frees on some cifs ioctls, and
clarify others to make more obvious that no data is returned.

Signed-off-by: default avatarSteve French <smfrench@gmail.com>
Acked-by: default avatarSachin Prabhu <sprabhu@redhat.com>
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 588e5ed8

fs/cifs/smb2ops.c

+4 −5
Original line number Diff line number Diff line
@@ -282,7 +282,7 @@ SMB3_request_interfaces(const unsigned int xid, struct cifs_tcon *tcon) 
		cifs_dbg(FYI, "Link Speed %lld\n",

			le64_to_cpu(out_buf->LinkSpeed));

	}



	kfree(out_buf);

	return rc;

}

#endif /* STATS2 */
@@ -695,6 +695,7 @@ smb2_clone_range(const unsigned int xid, 


cchunk_out:

	kfree(pcchunk);

	kfree(retbuf);

	return rc;

}
@@ -819,7 +820,6 @@ smb2_duplicate_extents(const unsigned int xid, 
{

	int rc;

	unsigned int ret_data_len;

	char *retbuf = NULL;

	struct duplicate_extents_to_file dup_ext_buf;

	struct cifs_tcon *tcon = tlink_tcon(trgtfile->tlink);
@@ -845,7 +845,7 @@ smb2_duplicate_extents(const unsigned int xid, 
			FSCTL_DUPLICATE_EXTENTS_TO_FILE,

			true /* is_fsctl */, (char *)&dup_ext_buf,

			sizeof(struct duplicate_extents_to_file),

			(char **)&retbuf,

			NULL,

			&ret_data_len);



	if (ret_data_len > 0)
@@ -868,7 +868,6 @@ smb3_set_integrity(const unsigned int xid, struct cifs_tcon *tcon, 
		   struct cifsFileInfo *cfile)

{

	struct fsctl_set_integrity_information_req integr_info;

	char *retbuf = NULL;

	unsigned int ret_data_len;



	integr_info.ChecksumAlgorithm = cpu_to_le16(CHECKSUM_TYPE_UNCHANGED);
@@ -880,7 +879,7 @@ smb3_set_integrity(const unsigned int xid, struct cifs_tcon *tcon, 
			FSCTL_SET_INTEGRITY_INFORMATION,

			true /* is_fsctl */, (char *)&integr_info,

			sizeof(struct fsctl_set_integrity_information_req),

			(char **)&retbuf,

			NULL,

			&ret_data_len);



}