Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit af586098 authored by Phillip Potter's avatar Phillip Potter Committed by Greg Kroah-Hartman
Browse files

leds: lp5523: check return value of lp5xx_read and jump to cleanup code 



commit 6647f7a06eb030a2384ec71f0bb2e78854afabfe upstream.

Check return value of lp5xx_read and if non-zero, jump to code at end of
the function, causing lp5523_stop_all_engines to be executed before
returning the error value up the call chain. This fixes the original
commit (248b57015f35) which was reverted due to the University of Minnesota
problems.

Cc: stable <stable@vger.kernel.org>
Acked-by: default avatarJacek Anaszewski <jacek.anaszewski@gmail.com>
Signed-off-by: default avatarPhillip Potter <phil@philpotter.co.uk>
Link: https://lore.kernel.org/r/20210503115736.2104747-10-gregkh@linuxfoundation.org


Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@linuxfoundation.org>
parent 812650c6

drivers/leds/leds-lp5523.c

+3 −1
Original line number Diff line number Diff line
@@ -318,7 +318,9 @@ static int lp5523_init_program_engine(struct lp55xx_chip *chip) 


	/* Let the programs run for couple of ms and check the engine status */

	usleep_range(3000, 6000);

	lp55xx_read(chip, LP5523_REG_STATUS, &status);

	ret = lp55xx_read(chip, LP5523_REG_STATUS, &status);

	if (ret)

		goto out;

	status &= LP5523_ENG_STATUS_MASK;



	if (status != LP5523_ENG_STATUS_MASK) {