Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Unverified Commit 92202621 authored by Vincent Guittot's avatar Vincent Guittot Committed by Alexander Grund
Browse files

UPSTREAM: sched/fair: Fix FTQ noise bench regression



A regression of the FTQ noise has been reported by Ying Huang,
on the following hardware:

  8 threads Intel(R) Core(TM)i7-4770 CPU @ 3.40GHz with 8G memory

... which was caused by this commit:

  commit 4e5160766fcc ("sched/fair: Propagate asynchrous detach")

The only part of the patch that can increase the noise is the update
of blocked load of group entity in update_blocked_averages().

We can optimize this call and skip the update of group entity if its load
and utilization are already null and there is no pending propagation of load
in the task group.

This optimization partly restores the noise score. A more agressive
optimization has been tried but has shown worse score.

Reported-by: default avatar <ying.huang@linux.intel.com>
Signed-off-by: default avatarVincent Guittot <vincent.guittot@linaro.org>
Signed-off-by: default avatarPeter Zijlstra (Intel) <peterz@infradead.org>
Cc: Linus Torvalds <torvalds@linux-foundation.org>
Cc: Mike Galbraith <efault@gmx.de>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: dietmar.eggemann@arm.com
Cc: ying.huang@intel.com
Fixes: 4e5160766fcc ("sched/fair: Propagate asynchrous detach")
Link: http://lkml.kernel.org/r/1489758442-2877-1-git-send-email-vincent.guittot@linaro.org


[ Fixed typos, improved layout. ]
Signed-off-by: default avatarIngo Molnar <mingo@kernel.org>
(cherry picked from commit bc4278987e3874da62edf585fe8b3bdd9b53f638)
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
Change-Id: I8b4018257c9c9f9cc5a0ed701b8e296a45781271
Signed-off-by: default avatarGreg Kroah-Hartman <gregkh@google.com>
parent ec25b90d
Loading
Loading
Loading
Loading
0% Loading or .
You are about to add 0 people to the discussion. Proceed with caution.
Please register or to comment