Donate to e Foundation | Murena handsets with /e/OS | Own a part of Murena! Learn more

Commit 44d8abb6 authored by Jaiju Yesudasan's avatar Jaiju Yesudasan Committed by Gerrit - the friendly Code Review server
Browse files

adv7481: return error when PLL lock fails 



Return error instead of default width and height when PLL lock fails.

Suggested-by: default avatarSuprith Malligere <c_suprit@qti.qualcomm.com>
Change-Id: I80880e9d1f6bcd5d6df87f74d005f9c79f91f096
Signed-off-by: default avatarJaiju Yesudasan <cjaijuy@codeaurora.org>
parent 14f6bfee

drivers/media/i2c/adv7481.c

+1 −15
Original line number Diff line number Diff line
@@ -55,8 +55,6 @@ 
#define LOCK_MAX_SLEEP		6000

#define LOCK_NUM_TRIES		200



#define MAX_DEFAULT_WIDTH       1280

#define MAX_DEFAULT_HEIGHT      720

#define MAX_DEFAULT_FRAME_RATE  60

#define MAX_DEFAULT_PIX_CLK_HZ  74240000
@@ -1576,8 +1574,7 @@ static int adv7481_get_hdmi_timings(struct adv7481_state *state, 
	} else {

		pr_err("%s(%d): PLL not locked return EBUSY\n",

				__func__, __LINE__);

		ret = -EBUSY;

		goto set_default;

		return -EBUSY;

	}



	/* Check Timing Lock */
@@ -1697,17 +1694,6 @@ static int adv7481_get_hdmi_timings(struct adv7481_state *state, 
						(hdmi_params->pix_rep + 1));

	}



set_default:

	if (ret) {

		pr_debug("%s(%d), error %d resort to default fmt\n",

			__func__, __LINE__, ret);

		vid_params->act_pix = MAX_DEFAULT_WIDTH;

		vid_params->act_lines = MAX_DEFAULT_HEIGHT;

		vid_params->fr_rate = MAX_DEFAULT_FRAME_RATE;

		vid_params->pix_clk = MAX_DEFAULT_PIX_CLK_HZ;

		vid_params->intrlcd = 0;

		ret = 0;

	}



	pr_debug("%s(%d), adv7481 TMDS Resolution: %d x %d @ %d fps\n",

			__func__, __LINE__,